Fixed two rare scenarios where the state for getlabel would be invalid after stopping the script while waiting for label#94
Open
Tranq1 wants to merge 57 commits intoUOOutlands:outlandsfrom
Conversation
Stop using the ConfigurationManager because that file changes when the program is run. This makes it difficult for launchers to ship good settings files.
This allows us to shift a bunch of code out of the packet handlers and into the individual files that handle each of these features.
fix dummy save Fix getName
They just return -1. This partially fixes UOOutlands#32.
To get local variables, just put unsetvar at the end of the script. Fixes UOOutlands#37
Dead feature. Hasn't been used in a decade.
rename expresson blessed with invul
…ing to InvalidOperationException
…d after stopping the script while waiting for label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bugfix fixes two scenarios:
The first one occurred when the script was stopped after the first label arrived but while still waiting out the 500ms pause, which would lead to the _onLabelMessage action not being removed and thus blocking all messages from showing for the serial that was last polled by getlabel.
The second, more serious one would occur if the script was stopped before the first label arrived, thus leaving the state at WAITING_FOR_FIRST_LABEL. This would lead to the command returning false and being stuck in a loop until the client is restarted.